From b300de9ac244ef5fd315228bce69c2b938dc77f4 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Sun, 11 Sep 2022 14:37:57 +0200 Subject: [PATCH] Makefile.am: add "-Wextra -Wshadow" Both of these options enable useful warnings; let's use them. Signed-off-by: Laszlo Ersek --- Makefile.am | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index 69976bf..93686ab 100644 --- a/Makefile.am +++ b/Makefile.am @@ -24,7 +24,7 @@ EXTRA_DIST = miniexpect.3 lib_LTLIBRARIES = libminiexpect.la libminiexpect_la_SOURCES = miniexpect.c miniexpect.h -libminiexpect_la_CFLAGS = $(PCRE2_CFLAGS) -Wall +libminiexpect_la_CFLAGS = $(PCRE2_CFLAGS) -Wall -Wextra -Wshadow libminiexpect_la_LIBADD = $(PCRE2_LIBS) libminiexpect_la_LDFLAGS = -version-info 0:0:0 @@ -33,7 +33,7 @@ libminiexpect_la_LDFLAGS = -version-info 0:0:0 noinst_PROGRAMS = example-sshpass example_sshpass_SOURCES = example-sshpass.c -example_sshpass_CFLAGS = $(PCRE2_CFLAGS) -Wall +example_sshpass_CFLAGS = $(PCRE2_CFLAGS) -Wall -Wextra -Wshadow example_sshpass_LDADD = libminiexpect.la # Tests. @@ -45,15 +45,15 @@ check_PROGRAMS = \ test-multi-match test_spawn_SOURCES = test-spawn.c tests.h miniexpect.h -test_spawn_CFLAGS = $(PCRE2_CFLAGS) -Wall +test_spawn_CFLAGS = $(PCRE2_CFLAGS) -Wall -Wextra -Wshadow test_spawn_LDADD = libminiexpect.la test_ls_version_SOURCES = test-ls-version.c tests.h miniexpect.h -test_ls_version_CFLAGS = $(PCRE2_CFLAGS) -Wall +test_ls_version_CFLAGS = $(PCRE2_CFLAGS) -Wall -Wextra -Wshadow test_ls_version_LDADD = libminiexpect.la test_multi_match_SOURCES = test-multi-match.c tests.h miniexpect.h -test_multi_match_CFLAGS = $(PCRE2_CFLAGS) -Wall +test_multi_match_CFLAGS = $(PCRE2_CFLAGS) -Wall -Wextra -Wshadow test_multi_match_LDADD = libminiexpect.la # parallel-tests breaks the ability to put 'valgrind' into -- 1.8.3.1