From: Richard W.M. Jones <rjones@redhat.com>
Date: Tue, 29 Nov 2011 17:13:17 +0000 (+0000)
Subject: ocaml: Fix memory leak in bindings for functions that return buffers.
X-Git-Tag: 1.14.5~12
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=f1ea1ec101df19a16b85a592564a284ebe8e6bf3;p=libguestfs.git

ocaml: Fix memory leak in bindings for functions that return buffers.

RBufferOut binding didn't free the buffer after copying it onto
the OCaml heap.

Found by valgrind.
(cherry picked from commit 6bd0eec12f2e39360847bfe7a9f50628cc89ed8e)
---

diff --git a/generator/generator_ocaml.ml b/generator/generator_ocaml.ml
index 4f7548c..10c18e3 100644
--- a/generator/generator_ocaml.ml
+++ b/generator/generator_ocaml.ml
@@ -625,6 +625,7 @@ copy_table (char * const * argv)
        | RBufferOut _ ->
            pr "  rv = caml_alloc_string (size);\n";
            pr "  memcpy (String_val (rv), r, size);\n";
+           pr "  free (r);\n"
       );
 
       pr "  CAMLreturn (rv);\n";