From: Richard W.M. Jones <rjones@redhat.com>
Date: Thu, 5 Oct 2023 13:04:26 +0000 (+0100)
Subject: Note about why dependency calculations were broken
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=e192328396b78f8d292507bf45004bb4890e89fd;hp=87cfd2eaa3f190373d48baf4c4b706be99df2348;p=fedora-ocaml-rebuild.git

Note about why dependency calculations were broken

Dependency calculation was only being done partially as the list of
fedora source packages was incomplete.  After examination of the log I
saw:

  + echo 'ocaml-pcre2: package is not checked out locally'
  ocaml-pcre2: package is not checked out locally
  + exit 1

For some reason this did not cause the function (and goals) to exit.
Is it a bug in goals?  Anyway make the error more prominent at least.
---

diff --git a/Goalfile b/Goalfile
index 4c18a32..e689a21 100644
--- a/Goalfile
+++ b/Goalfile
@@ -241,7 +241,8 @@ pure function get-source-packages () returning strings = {
         elif [ -f $pkg/%fedora-branch/dead.package ]; then
             echo "WARNING: $pkg: is a dead package, ignored" >&2
         else
-            echo "$pkg: package is not checked out locally" >&2
+            echo "ERROR: $pkg: package is not checked out locally" >&2
+            # This does NOT exit the script, why???
             exit 1
         fi
     done