From: Richard W.M. Jones <rjones@redhat.com>
Date: Fri, 22 Oct 2010 11:13:07 +0000 (+0100)
Subject: inspector: Add comment about why --fish option implies write mode.
X-Git-Tag: 1.4.6~2
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=cf4ce99a68626582c0870df30115273284a0960e;p=libguestfs.git

inspector: Add comment about why --fish option implies write mode.
(cherry picked from commit 2109d8d86aeb66093e0a9f41d3693693e3df66d5)
---

diff --git a/inspector/virt-inspector b/inspector/virt-inspector
index dc15f0d..60d5869 100755
--- a/inspector/virt-inspector
+++ b/inspector/virt-inspector
@@ -200,7 +200,15 @@ if ($version) {
 pod2usage (__"virt-inspector: no image or VM names given") if @ARGV == 0;
 
 my $rw = 0;
+
+# XXX This is a bug: Originally we intended to open the guest with
+# rw=>1 in order to tell Sys::Guestfs::Lib that we should disallow
+# active domains.  However this also has the effect of opening the
+# disk image in write mode, and in any case we don't use this option
+# in guestfish any more since we moved all the inspection code into
+# the core library.  We should drop the fish output modes completely.
 $rw = 1 if $output eq "fish";
+
 my $g;
 my @images;
 if ($uri) {