From: Richard W.M. Jones <rjones@redhat.com>
Date: Tue, 15 Mar 2011 14:52:03 +0000 (+0000)
Subject: ruby: Remove unnecessary checking around StringValueCStr (RHBZ#667610).
X-Git-Tag: 1.9.11~4
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=c50ed37b71a50b2570a3b16a82a9d73e026be739;p=libguestfs.git

ruby: Remove unnecessary checking around StringValueCStr (RHBZ#667610).
---

diff --git a/generator/generator_ruby.ml b/generator/generator_ruby.ml
index a2a112a..8be9369 100644
--- a/generator/generator_ruby.ml
+++ b/generator/generator_ruby.ml
@@ -351,11 +351,7 @@ get_all_event_callbacks (guestfs_h *g, size_t *len_rtn)
         function
         | Pathname n | Device n | Dev_or_Path n | String n | Key n
         | FileIn n | FileOut n ->
-            pr "  Check_Type (%sv, T_STRING);\n" n;
             pr "  const char *%s = StringValueCStr (%sv);\n" n n;
-            pr "  if (!%s)\n" n;
-            pr "    rb_raise (rb_eTypeError, \"expected string for parameter %%s of %%s\",\n";
-            pr "              \"%s\", \"%s\");\n" n name
         | BufferIn n ->
             pr "  Check_Type (%sv, T_STRING);\n" n;
             pr "  const char *%s = RSTRING (%sv)->ptr;\n" n n;
@@ -411,7 +407,6 @@ get_all_event_callbacks (guestfs_h *g, size_t *len_rtn)
              | Int64 n ->
                  pr "    optargs_s.%s = NUM2LL (v);\n" n;
              | String _ ->
-                 pr "    Check_Type (v, T_STRING);\n";
                  pr "    optargs_s.%s = StringValueCStr (v);\n" n
              | _ -> assert false
             );