From: Richard W.M. Jones Date: Tue, 17 May 2011 14:50:16 +0000 (+0100) Subject: generator: Check the flags fields. X-Git-Tag: 1.11.7~4 X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=b43482964a8c7e19f47943506872cd58601c28e9;p=libguestfs.git generator: Check the flags fields. --- diff --git a/generator/generator_checks.ml b/generator/generator_checks.ml index 0fb8ea4..8ee06b5 100644 --- a/generator/generator_checks.ml +++ b/generator/generator_checks.ml @@ -188,6 +188,38 @@ let () = in loop proc_nrs; + (* Check flags. *) + List.iter ( + fun (name, _, _, flags, _, _, _) -> + List.iter ( + function + | ProtocolLimitWarning + | DangerWillRobinson + | FishOutput _ + | NotInFish + | NotInDocs + | Progress -> () + | FishAlias n -> + if contains_uppercase n then + failwithf "%s: guestfish alias %s should not contain uppercase chars" name n; + if String.contains n '_' then + failwithf "%s: guestfish alias %s should not contain '_'" name n + | DeprecatedBy n -> + (* 'n' must be a cross-ref to the name of another action. *) + if not (List.exists ( + function + | (n', _, _, _, _, _, _) when n = n' -> true + | _ -> false + ) all_functions) then + failwithf "%s: DeprecatedBy flag must be cross-reference to another action" name + | Optional n -> + if contains_uppercase n then + failwithf "%s: Optional group name %s should not contain uppercase chars" name n; + if String.contains n '-' || String.contains n '_' then + failwithf "%s: Optional group name %s should not contain '-' or '_'" name n + ) flags + ) (all_functions @ fish_commands); + (* Check tests. *) List.iter ( function