From: Jim Meyering <meyering@redhat.com>
Date: Tue, 18 Aug 2009 13:03:55 +0000 (+0200)
Subject: build: suppress an ignored-dup-return-value warning
X-Git-Tag: 1.0.68~20
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=93ab20eb367b1c177a73620222afdf1f616dea1c;p=libguestfs.git

build: suppress an ignored-dup-return-value warning

* src/guestfs.c (guestfs_launch): Handle dup failure.
---

diff --git a/src/guestfs.c b/src/guestfs.c
index ecdf9e5..1cd4f9e 100644
--- a/src/guestfs.c
+++ b/src/guestfs.c
@@ -1162,11 +1162,18 @@ guestfs_launch (guestfs_h *g)
     close (1);
     close (wfd[1]);
     close (rfd[0]);
-    dup (wfd[0]);
-    dup (rfd[1]);
+
+    int fail = 0;
+    fail |= dup (wfd[0]);
+    fail |= dup (rfd[1]);
     close (wfd[0]);
     close (rfd[1]);
 
+    if (fail) {
+      perror ("dup failed");
+      _exit (1);
+    }
+
 #if 0
     /* Set up a new process group, so we can signal this process
      * and all subprocesses (eg. if qemu is really a shell script).