From: Richard W.M. Jones <rjones@redhat.com>
Date: Thu, 21 Apr 2011 16:29:44 +0000 (+0100)
Subject: list-applications: If software hive is missing, this is an error.
X-Git-Tag: 1.11.3~5
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=782f3a36469ca396dbf998ea82af2699153be3ed;p=libguestfs.git

list-applications: If software hive is missing, this is an error.

virt-inspector would exit silently if list-applications failed along
this error path.
---

diff --git a/src/inspect_apps.c b/src/inspect_apps.c
index d7634d8..a41c46c 100644
--- a/src/inspect_apps.c
+++ b/src/inspect_apps.c
@@ -430,11 +430,11 @@ list_applications_windows (guestfs_h *g, struct inspect_fs *fs)
             fs->windows_systemroot);
 
   char *software_path = guestfs___case_sensitive_path_silently (g, software);
-  if (!software_path)
-    /* If the software hive doesn't exist, just accept that we cannot
-     * list windows apps.
-     */
-    return 0;
+  if (!software_path) {
+    /* Missing software hive is a problem. */
+    error (g, "no HKLM\\SOFTWARE hive found in the guest");
+    return NULL;
+  }
 
   struct guestfs_application_list *ret = NULL;
   hive_h *h = NULL;