From: Richard W.M. Jones <rjones@redhat.com>
Date: Tue, 23 Aug 2011 18:50:11 +0000 (+0100)
Subject: Coverity: fix memory leak along error path.
X-Git-Tag: 1.12.5~12
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=43c9be7f7bef569c70624e3a07675f9a77c74192;p=libguestfs.git

Coverity: fix memory leak along error path.
(cherry picked from commit ce18be33cd5279a8d4120eedd037400c275585c0)
---

diff --git a/src/appliance.c b/src/appliance.c
index 9f86954..836e679 100644
--- a/src/appliance.c
+++ b/src/appliance.c
@@ -402,6 +402,12 @@ check_for_cached_appliance (guestfs_h *g,
   /* Releases the lock on checksum. */
   if (close (fd) == -1) {
     perrorf (g, "close");
+    /* Allocated in hard_link_to_cached_appliance above, must be
+     * freed along this error path.
+     */
+    free (*kernel);
+    free (*initrd);
+    free (*appliance);
     return -1;
   }
 
@@ -540,6 +546,12 @@ build_supermin_appliance (guestfs_h *g,
   /* Releases the lock on checksum. */
   if (close (fd) == -1) {
     perrorf (g, "close");
+    /* Allocated in hard_link_to_cached_appliance above, must be
+     * freed along this error path.
+     */
+    free (*kernel);
+    free (*initrd);
+    free (*appliance);
     return -1;
   }