From: Richard Jones <rjones@redhat.com>
Date: Wed, 16 Jun 2010 13:29:39 +0000 (+0100)
Subject: TODO: Add a note about impl of list-filesystems.
X-Git-Tag: 1.3.21~2
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=1e568f057e8bb7b36cc14e0e531d74b75ad9cb6c;p=libguestfs.git

TODO: Add a note about impl of list-filesystems.
---

diff --git a/TODO b/TODO
index e90d408..da39f1a 100644
--- a/TODO
+++ b/TODO
@@ -323,6 +323,15 @@ New guestfish commands
 
 'list-filesystems' => list mountable filesystems
 
+We could implement this as a new API call, replacing a number of areas
+of the current code where this is done already (in virt-inspector and
+elsewhere).  What we normally do to find out if a partition contains a
+mountable filesystem is to just blindly mount it, and see if that
+succeeds.  However the kernel won't let us do this if the filesystem
+is already mounted somewhere, so a naive implementation of this in the
+daemon won't work.  We would have to check if the partition was
+already mounted.
+
 Could we make guestfish interactive if commands are used without params?
 ------------------------------------------------------------------------