From: Richard W.M. Jones <rjones@redhat.com>
Date: Fri, 5 Nov 2010 15:07:11 +0000 (+0000)
Subject: fish: Suggest safer form of eval.
X-Git-Tag: 1.6.2~52
X-Git-Url: http://git.annexia.org/?a=commitdiff_plain;h=13980af777a43407973340110699e6bb9fb10ccb;p=libguestfs.git

fish: Suggest safer form of eval.

eval "$(guestfish --listen)"

instead of various other forms.

(Thanks Eric Blake).
(cherry picked from commit be728962ff636e260f09dca6a1175c442d687551)
---

diff --git a/fish/guestfish.pod b/fish/guestfish.pod
index 4f4e1f0..15b759f 100644
--- a/fish/guestfish.pod
+++ b/fish/guestfish.pod
@@ -140,7 +140,7 @@ To list what is available do:
 
 =head2 Remote control
 
- eval `guestfish --listen`
+ eval "`guestfish --listen`"
  guestfish --remote add-ro disk.img
  guestfish --remote run
  guestfish --remote lvs
@@ -730,7 +730,7 @@ up a guestfish process each time.
 
 Start a guestfish server process using:
 
- eval `guestfish --listen`
+ eval "`guestfish --listen`"
 
 and then send it commands by doing:
 
@@ -750,9 +750,9 @@ The C<eval> statement sets the environment variable C<$GUESTFISH_PID>,
 which is how the I<--remote> option knows where to send the commands.
 You can have several guestfish listener processes running using:
 
- eval `guestfish --listen`
+ eval "`guestfish --listen`"
  pid1=$GUESTFISH_PID
- eval `guestfish --listen`
+ eval "`guestfish --listen`"
  pid2=$GUESTFISH_PID
  ...
  guestfish --remote=$pid1 cmd