X-Git-Url: http://git.annexia.org/?a=blobdiff_plain;f=src%2Fappliance.c;h=836e6792256e1275e5a0c7f1eaf7f855814ae560;hb=2faef37957629e0436308e759211209e5e823ee0;hp=1df8c3616c97d1b85e4cdb613087bd0d40d13b09;hpb=635af5be04265f845186b40e9a9fe7b102ad6909;p=libguestfs.git

diff --git a/src/appliance.c b/src/appliance.c
index 1df8c36..836e679 100644
--- a/src/appliance.c
+++ b/src/appliance.c
@@ -241,7 +241,7 @@ calculate_supermin_checksum (guestfs_h *g, const char *supermin_path)
     return NULL;
   }
 
-  if (pclose (pp) == -1) {
+  if (pclose (pp) != 0) {
     warning (g, "pclose: %m");
     return NULL;
   }
@@ -402,6 +402,12 @@ check_for_cached_appliance (guestfs_h *g,
   /* Releases the lock on checksum. */
   if (close (fd) == -1) {
     perrorf (g, "close");
+    /* Allocated in hard_link_to_cached_appliance above, must be
+     * freed along this error path.
+     */
+    free (*kernel);
+    free (*initrd);
+    free (*appliance);
     return -1;
   }
 
@@ -540,6 +546,12 @@ build_supermin_appliance (guestfs_h *g,
   /* Releases the lock on checksum. */
   if (close (fd) == -1) {
     perrorf (g, "close");
+    /* Allocated in hard_link_to_cached_appliance above, must be
+     * freed along this error path.
+     */
+    free (*kernel);
+    free (*initrd);
+    free (*appliance);
     return -1;
   }