X-Git-Url: http://git.annexia.org/?a=blobdiff_plain;f=daemon%2Fproto.c;h=acd66017fd91493f397fa3310677d7fa82f19eef;hb=9af96c41f64567e6fbe0dd25f6ffa90385e9c49a;hp=ffb4a4e8db3301f26b0907b4253276deda2fd456;hpb=38f9222d21fb3c3005872de05247ff16a66db945;p=libguestfs.git diff --git a/daemon/proto.c b/daemon/proto.c index ffb4a4e..acd6601 100644 --- a/daemon/proto.c +++ b/daemon/proto.c @@ -1,5 +1,5 @@ /* libguestfs - the guestfsd daemon - * Copyright (C) 2009 Red Hat Inc. + * Copyright (C) 2009 Red Hat Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -47,6 +47,8 @@ main_loop (int _sock) char lenbuf[4]; unsigned len; struct guestfs_message_header hdr; + struct timeval start_t, end_t; + int64_t start_us, end_us, elapsed_us; sock = _sock; @@ -102,6 +104,10 @@ main_loop (int _sock) } #endif + /* In verbose mode, display the time taken to run each command. */ + if (verbose) + gettimeofday (&start_t, NULL); + /* Decode the message header. */ xdrmem_create (&xdr, buf, len, XDR_DECODE); if (!xdr_guestfs_message_header (&xdr, &hdr)) { @@ -133,6 +139,21 @@ main_loop (int _sock) dispatch_incoming_message (&xdr); /* Note that dispatch_incoming_message will also send a reply. */ + /* In verbose mode, display the time taken to run each command. */ + if (verbose) { + gettimeofday (&end_t, NULL); + + start_us = (int64_t) start_t.tv_sec * 1000000 + start_t.tv_usec; + end_us = (int64_t) end_t.tv_sec * 1000000 + end_t.tv_usec; + elapsed_us = end_us - start_us; + fprintf (stderr, "proc %d (%s) took %d.%02d seconds\n", + proc_nr, + proc_nr >= 0 && proc_nr < GUESTFS_PROC_NR_PROCS + ? function_names[proc_nr] : "UNKNOWN PROCEDURE", + (int) (elapsed_us / 1000000), + (int) ((elapsed_us / 10000) % 100)); + } + cont: xdr_destroy (&xdr); free (buf); @@ -245,9 +266,14 @@ reply (xdrproc_t xdrp, char *ret) } if (xdrp) { + /* This can fail if the reply body is too large, for example + * if it exceeds the maximum message size. In that case + * we want to return an error message instead. (RHBZ#509597). + */ if (!(*xdrp) (&xdr, ret)) { - fprintf (stderr, "guestfsd: failed to encode reply body\n"); - exit (1); + reply_with_perror ("guestfsd: failed to encode reply body\n"); + xdr_destroy (&xdr); + return; } }