X-Git-Url: http://git.annexia.org/?a=blobdiff_plain;f=daemon%2Fmount.c;h=be289dade5865327f65bea16481c733c318b1173;hb=18ee38e1eac132b91706771285d1764641179804;hp=a915b44070071e6219e6a7099869ba54c3cb532d;hpb=33b638109ed66ea360b53b80b1f407b3a5f5ec39;p=libguestfs.git

diff --git a/daemon/mount.c b/daemon/mount.c
index a915b44..be289da 100644
--- a/daemon/mount.c
+++ b/daemon/mount.c
@@ -116,6 +116,7 @@ do_mount_vfs (const char *options, const char *vfstype,
     return -1;
   }
 
+  free (error);
   return 0;
 }
 
@@ -174,68 +175,49 @@ do_umount (const char *pathordevice)
   return 0;
 }
 
+/* Implement 'mounts' (mp==0) and 'mountpoints' (mp==1) calls. */
 static char **
 mounts_or_mountpoints (int mp)
 {
-  char *out, *err;
-  int r;
+  FILE *fp;
+  struct mntent *m;
   char **ret = NULL;
   int size = 0, alloc = 0;
-  char *p, *pend, *p2;
-  int len;
-  char matching[5 + sysroot_len];
   size_t i;
+  int r;
 
-  r = command (&out, &err, "mount", NULL);
-  if (r == -1) {
-    reply_with_error ("mount: %s", err);
-    free (out);
-    free (err);
-    return NULL;
-  }
-
-  free (err);
-
-  /* Lines have the format:
-   *   /dev/foo on /mountpoint type ...
+  /* NB: Eventually we should aim to parse /proc/self/mountinfo, but
+   * that requires custom parsing code.
    */
-  snprintf (matching, 5 + sysroot_len, " on %s", sysroot);
-
-  p = out;
-  while (p) {
-    pend = strchr (p, '\n');
-    if (pend) {
-      *pend = '\0';
-      pend++;
-    }
+  fp = setmntent ("/proc/mounts", "r");
+  if (fp == NULL) {
+    perror ("/proc/mounts");
+    exit (EXIT_FAILURE);
+  }
 
-    p2 = strstr (p, matching);
-    if (p2 != NULL) {
-      *p2 = '\0';
-      if (add_string (&ret, &size, &alloc, p) == -1) {
-        free (out);
+  while ((m = getmntent (fp)) != NULL) {
+    /* Allow a mount directory like "/sysroot". */
+    if (sysroot_len > 0 && STREQ (m->mnt_dir, sysroot)) {
+      if (add_string (&ret, &size, &alloc, m->mnt_fsname) == -1) {
+      error:
+        endmntent (fp);
         return NULL;
       }
-      if (mp) {
-        p2 += 4 + sysroot_len;	/* skip " on /sysroot" */
-        len = strcspn (p2, " ");
-
-        if (len == 0)		/* .. just /sysroot, so we turn it into "/" */
-          p2 = (char *) "/";
-        else
-          p2[len] = '\0';
-
-        if (add_string (&ret, &size, &alloc, p2) == -1) {
-          free (out);
-          return NULL;
-        }
-      }
+      if (mp &&
+          add_string (&ret, &size, &alloc, "/") == -1)
+        goto error;
+    }
+    /* Or allow a mount directory like "/sysroot/...". */
+    if (STRPREFIX (m->mnt_dir, sysroot) && m->mnt_dir[sysroot_len] == '/') {
+      if (add_string (&ret, &size, &alloc, m->mnt_fsname) == -1)
+        goto error;
+      if (mp &&
+          add_string (&ret, &size, &alloc, &m->mnt_dir[sysroot_len]) == -1)
+        goto error;
     }
-
-    p = pend;
   }
 
-  free (out);
+  endmntent (fp);
 
   if (add_string (&ret, &size, &alloc, NULL) == -1)
     return NULL;
@@ -298,50 +280,40 @@ compare_longest_first (const void *vp1, const void *vp2)
 int
 do_umount_all (void)
 {
-  char *out, *err;
-  int i, r;
+  FILE *fp;
+  struct mntent *m;
   char **mounts = NULL;
   int size = 0, alloc = 0;
-  char *p, *p2, *p3, *pend;
-  char matching[5 + sysroot_len];
+  char *err;
+  int i, r;
 
-  r = command (&out, &err, "mount", NULL);
-  if (r == -1) {
-    reply_with_error ("mount: %s", err);
-    free (out);
-    free (err);
-    return -1;
+  /* NB: Eventually we should aim to parse /proc/self/mountinfo, but
+   * that requires custom parsing code.
+   */
+  fp = setmntent ("/proc/mounts", "r");
+  if (fp == NULL) {
+    perror ("/proc/mounts");
+    exit (EXIT_FAILURE);
   }
 
-  free (err);
-
-  /* Lines have the format:
-   *   /dev/foo on /mountpoint type ...
-   */
-  snprintf (matching, 5 + sysroot_len, " on %s", sysroot);
-
-  p = out;
-  while (p) {
-    pend = strchr (p, '\n');
-    if (pend) {
-      *pend = '\0';
-      pend++;
+  while ((m = getmntent (fp)) != NULL) {
+    /* Allow a mount directory like "/sysroot". */
+    if (sysroot_len > 0 && STREQ (m->mnt_dir, sysroot)) {
+      if (add_string (&mounts, &size, &alloc, m->mnt_dir) == -1) {
+        endmntent (fp);
+        return -1;
+      }
     }
-
-    p2 = strstr (p, matching);
-    if (p2 != NULL) {
-      p2 += 4;
-      p3 = p2 + strcspn (p2, " ");
-      *p3 = '\0';
-      if (add_string (&mounts, &size, &alloc, p2) == -1) {
-        free (out);
+    /* Or allow a mount directory like "/sysroot/...". */
+    if (STRPREFIX (m->mnt_dir, sysroot) && m->mnt_dir[sysroot_len] == '/') {
+      if (add_string (&mounts, &size, &alloc, m->mnt_dir) == -1) {
+        endmntent (fp);
         return -1;
       }
     }
-
-    p = pend;
   }
-  free (out);
+
+  endmntent (fp);
 
   qsort (mounts, size, sizeof (char *), compare_longest_first);
 
@@ -381,7 +353,7 @@ do_mount_loop (const char *file, const char *mountpoint)
   }
 
   buf = sysroot_path (file);
-  if (!file) {
+  if (!buf) {
     reply_with_perror ("malloc");
     free (mp);
     return -1;
@@ -396,6 +368,7 @@ do_mount_loop (const char *file, const char *mountpoint)
     return -1;
   }
 
+  free (error);
   return 0;
 }