X-Git-Url: http://git.annexia.org/?a=blobdiff_plain;f=daemon%2Ffile.c;h=691f91735ce89bfd2143ec467c42eeff77f45a3c;hb=63c1d5dd6efb9b59a73a11f31aefdc55eaf28384;hp=9403100df8289111aad49c97826c273ebd86ab5e;hpb=eeaab2ba84441a96977281a4472b1bccb9ec80a9;p=libguestfs.git diff --git a/daemon/file.c b/daemon/file.c index 9403100..691f917 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -1,5 +1,5 @@ /* libguestfs - the guestfsd daemon - * Copyright (C) 2009 Red Hat Inc. + * Copyright (C) 2009-2011 Red Hat Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -25,7 +25,7 @@ #include #include -#include "../src/guestfs_protocol.h" +#include "guestfs_protocol.h" #include "daemon.h" #include "actions.h" @@ -349,6 +349,34 @@ do_write (const char *path, const char *content, size_t size) return 0; } +int +do_write_append (const char *path, const char *content, size_t size) +{ + int fd; + + CHROOT_IN; + fd = open (path, O_WRONLY | O_APPEND | O_CREAT | O_NOCTTY, 0666); + CHROOT_OUT; + + if (fd == -1) { + reply_with_perror ("open: %s", path); + return -1; + } + + if (xwrite (fd, content, size) == -1) { + reply_with_perror ("write"); + close (fd); + return -1; + } + + if (close (fd) == -1) { + reply_with_perror ("close: %s", path); + return -1; + } + + return 0; +} + char * do_read_file (const char *path, size_t *size_r) { @@ -408,29 +436,33 @@ do_read_file (const char *path, size_t *size_r) return r; } -char * -do_pread (const char *path, int count, int64_t offset, size_t *size_r) +static char * +pread_fd (int fd, int count, int64_t offset, size_t *size_r, + const char *display_path) { - int fd; ssize_t r; char *buf; + if (count < 0) { + reply_with_error ("count is negative"); + close (fd); + return NULL; + } + + if (offset < 0) { + reply_with_error ("offset is negative"); + close (fd); + return NULL; + } + /* The actual limit on messages is smaller than this. This check * just limits the amount of memory we'll try and allocate in the * function. If the message is larger than the real limit, that * will be caught later when we try to serialize the message. */ if (count >= GUESTFS_MESSAGE_MAX) { - reply_with_error ("%s: count is too large for the protocol, use smaller reads", path); - return NULL; - } - - CHROOT_IN; - fd = open (path, O_RDONLY); - CHROOT_OUT; - - if (fd == -1) { - reply_with_perror ("open: %s", path); + reply_with_error ("%s: count is too large for the protocol, use smaller reads", display_path); + close (fd); return NULL; } @@ -443,14 +475,14 @@ do_pread (const char *path, int count, int64_t offset, size_t *size_r) r = pread (fd, buf, count, offset); if (r == -1) { - reply_with_perror ("pread: %s", path); + reply_with_perror ("pread: %s", display_path); close (fd); free (buf); return NULL; } if (close (fd) == -1) { - reply_with_perror ("close: %s", path); + reply_with_perror ("close: %s", display_path); close (fd); free (buf); return NULL; @@ -463,6 +495,35 @@ do_pread (const char *path, int count, int64_t offset, size_t *size_r) return buf; } +char * +do_pread (const char *path, int count, int64_t offset, size_t *size_r) +{ + int fd; + + CHROOT_IN; + fd = open (path, O_RDONLY); + CHROOT_OUT; + + if (fd == -1) { + reply_with_perror ("open: %s", path); + return NULL; + } + + return pread_fd (fd, count, offset, size_r, path); +} + +char * +do_pread_device (const char *device, int count, int64_t offset, size_t *size_r) +{ + int fd = open (device, O_RDONLY); + if (fd == -1) { + reply_with_perror ("open: %s", device); + return NULL; + } + + return pread_fd (fd, count, offset, size_r, device); +} + static int pwrite_fd (int fd, const char *content, size_t size, int64_t offset, const char *display_path)