X-Git-Url: http://git.annexia.org/?a=blobdiff_plain;f=daemon%2Fdebug.c;h=d6e469b4cba3303693dbf31c579263f815e965e7;hb=f339cb33703fc1b561d9956c29c4eb0e57334a91;hp=e4a7f05586bf5a7cc76069541de8ba9def99f4d4;hpb=8be6c7056d18cd5aa5edddfc73bfd4206b038cee;p=libguestfs.git

diff --git a/daemon/debug.c b/daemon/debug.c
index e4a7f05..d6e469b 100644
--- a/daemon/debug.c
+++ b/daemon/debug.c
@@ -45,19 +45,23 @@ struct cmd {
 };
 
 static char *debug_help (const char *subcmd, int argc, char *const *const argv);
+static char *debug_env (const char *subcmd, int argc, char *const *const argv);
 static char *debug_fds (const char *subcmd, int argc, char *const *const argv);
+static char *debug_segv (const char *subcmd, int argc, char *const *const argv);
 static char *debug_sh (const char *subcmd, int argc, char *const *const argv);
 
 static struct cmd cmds[] = {
   { "help", debug_help },
+  { "env", debug_env },
   { "fds", debug_fds },
+  { "segv", debug_segv },
   { "sh", debug_sh },
   { NULL, NULL }
 };
 #endif
 
 char *
-do_debug (const char *subcmd, char *const *const argv)
+do_debug (char *subcmd, char **argv)
 {
 #if ENABLE_DEBUG_COMMAND
   int argc, i;
@@ -177,16 +181,68 @@ debug_fds (const char *subcmd, int argc, char *const *const argv)
   return out;
 }
 
-/* Run an arbitrary shell command. */
+/* Force a segfault in the daemon. */
+static char *
+debug_segv (const char *subcmd, int argc, char *const *const argv)
+{
+  *(int*)0 = 0;
+  return NULL;
+}
+
+/* Run an arbitrary shell command using /bin/sh from the appliance.
+ *
+ * Note this is somewhat different from the ordinary guestfs_sh command
+ * because it's not using the guest shell, and is not chrooted.
+ *
+ * Also we ignore any errors and you can see the full output if you
+ * add 2>&1 to the end of the command string.
+ */
 static char *
 debug_sh (const char *subcmd, int argc, char *const *const argv)
 {
+  char *cmd;
+  int len, i, j;
+  char *out;
+
+  if (argc < 1) {
+    reply_with_error ("debug: sh: expecting a command to run");
+    return NULL;
+  }
+
+  /* guestfish splits the parameter(s) into a list of strings,
+   * and we have to reassemble them here.  Not ideal. XXX
+   */
+  for (i = len = 0; i < argc; ++i)
+    len += strlen (argv[i]) + 1;
+  cmd = malloc (len);
+  if (!cmd) {
+    reply_with_perror ("malloc");
+    return NULL;
+  }
+  for (i = j = 0; i < argc; ++i) {
+    len = strlen (argv[i]);
+    memcpy (&cmd[j], argv[i], len);
+    j += len;
+    cmd[j] = ' ';
+    j++;
+  }
+  cmd[j-1] = '\0';
+
+  command (&out, NULL, "/bin/sh", "-c", cmd, NULL);
+  free (cmd);
+  return out;
+}
+
+/* Print the environment that commands get (by running external printenv). */
+static char *
+debug_env (const char *subcmd, int argc, char *const *const argv)
+{
   int r;
   char *out, *err;
 
-  r = commandv (&out, &err, argv);
+  r = command (&out, &err, "printenv", NULL);
   if (r == -1) {
-    reply_with_error ("ps: %s", err);
+    reply_with_error ("printenv: %s", err);
     free (out);
     free (err);
     return NULL;