X-Git-Url: http://git.annexia.org/?a=blobdiff_plain;ds=sidebyside;f=extratests%2FMakefile.am;h=32dcbf2b5a39e66304345d323c6e71d729e2dc73;hb=b7addee24d211014086c44bcef6a0c799e4fb987;hp=c08d3dd4428a95bda045f54d690bda6cf5b34f27;hpb=cee513112adcf4084d6be9e3b5037b7b54c9f514;p=libguestfs.git

diff --git a/extratests/Makefile.am b/extratests/Makefile.am
index c08d3dd..32dcbf2 100644
--- a/extratests/Makefile.am
+++ b/extratests/Makefile.am
@@ -22,8 +22,34 @@
 #   - the disks of these guests are accessible by the current user
 #     (tip: add yourself to the 'disk' group)
 #   - valgrind
+#   - libtool
 #
 # These tests may fail for reasons which aren't necessarily real problems.
+#
+# XXX Not tested:
+#
+# ../clone/virt-sysprep
+#   - hard to test because it's a shell script
+#
+# ../edit/virt-edit
+#
+# Perl bindings
+# ../edit/virt-edit -e
+# ../tools/virt-win-reg (Perl)
+# ../tools/virt-make-fs (Perl)
+#   - hard because Perl doesn't cooperate by freeing memory
+#
+# Python bindings
+#   - as for Perl
+#
+# Ruby bindings
+#   - these look feasible to test using valgrind
+#
+# Java bindings
+#
+# ../fuse/guestmount
+#   - hard to test because guestmount forks into the background, and
+#     if valgrind reports errors it doesn't stop the test shell script
 
 EXTRA_DIST = suppressions
 
@@ -32,7 +58,7 @@ VG = valgrind \
 	--leak-check=full \
 	--error-exitcode=119 \
 	--suppressions=$(abs_srcdir)/suppressions
-RUN_VG = ../run $(VG)
+RUN_VG = $(abs_top_builddir)/run $(VG)
 
 export LIBVIRT_DEFAULT_URI = \
 	qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock-ro
@@ -43,6 +69,7 @@ GUESTS = $(shell virsh -c $(LIBVIRT_DEFAULT_URI) list --all | \
 		 awk '{print $$2}')
 
 extra-tests: \
+	test-prerequisites \
 	test-capitests \
 	test-tools-null \
 	test-tools-internal \
@@ -53,6 +80,16 @@ extra-tests: \
 	test-resize \
 	test-sparsify
 
+test-prerequisites:
+	@libtool --help >/dev/null 2>&1 || { \
+	  echo "extra-tests: libtool is not installed"; \
+	  exit 1; \
+	}
+	@valgrind --help >/dev/null 2>&1 || { \
+	  echo "extra-tests: valgrind is not installed"; \
+	  exit 1; \
+	}
+
 # Null invocations of the basic tools shouldn't leak memory.
 test-tools-null:
 	$(RUN_VG) ../fish/guestfish -N part exit
@@ -113,14 +150,6 @@ test-resize:
 test-sparsify:
 	$(MAKE) -C ../sparsify VG="$(VG)" check
 
-# XXX Not tested:
-# ../clone/virt-sysprep
-# ../edit/virt-edit
-# ../edit/virt-edit -e
-# ../fuse/guestmount
-# ../tools/virt-win-reg (Perl)
-# ../tools/virt-make-fs (Perl)
-
 # Run capitests under valgrind.
 test-capitests:
 	$(MAKE) -C ../capitests VG="$(RUN_VG)" check