use strict;
use Sys::Guestfs;
-use Sys::Guestfs::Lib qw(open_guest get_partitions resolve_windows_path
- inspect_all_partitions inspect_partition
- inspect_operating_systems mount_operating_system);
+use Sys::Guestfs::Lib qw(open_guest);
use Pod::Usage;
use Getopt::Long;
use File::Temp qw/tempfile/;
+use File::Basename;
use Locale::TextDomain 'libguestfs';
=encoding utf8
=cut
+my $backup;
+
+=item B<--backup extension> | B<-b extension>
+
+Create a backup of the original file I<in the guest disk image>.
+The backup has the original filename with C<extension> added.
+
+Usually the first character of C<extension> would be a dot C<.>
+so you would write:
+
+ virt-edit -b .orig [etc]
+
+By default, no backup file is made.
+
+=cut
+
my $uri;
=item B<--connect URI> | B<-c URI>
=cut
+my $format;
+
+=item B<--format> raw
+
+Specify the format of disk images given on the command line. If this
+is omitted then the format is autodetected from the content of the
+disk image.
+
+If disk images are requested from libvirt, then this program asks
+libvirt for this information. In this case, the value of the format
+parameter is ignored.
+
+If working with untrusted raw-format guest disk images, you should
+ensure the format is always specified.
+
+=cut
+
my $expr;
=item B<--expr EXPR> | B<-e EXPR>
GetOptions ("help|?" => \$help,
"version" => \$version,
"connect|c=s" => \$uri,
+ "format=s" => \$format,
"expr|e=s" => \$expr,
+ "backup|b=s" => \$backup,
) or pod2usage (2);
pod2usage (1) if $help;
if ($version) {
my $g;
if ($uri) {
- $g = open_guest (\@ARGV, address => $uri, rw => 1);
+ $g = open_guest (\@ARGV, address => $uri, rw => 1, format => $format);
} else {
- $g = open_guest (\@ARGV, rw => 1);
+ $g = open_guest (\@ARGV, rw => 1, format => $format);
}
$g->launch ();
-# List of possible filesystems.
-my @partitions = get_partitions ($g);
-
-# Now query each one to build up a picture of what's in it.
-my %fses =
- inspect_all_partitions ($g, \@partitions,
- use_windows_registry => 0);
-
-my $oses = inspect_operating_systems ($g, \%fses);
-
-my @roots = keys %$oses;
-die __"multiboot operating systems are not supported by virt-edit" if @roots > 1;
-my $root_dev = $roots[0];
-
-my $os = $oses->{$root_dev};
-mount_operating_system ($g, $os, 0);
+my @roots = $g->inspect_os ();
+if (@roots == 0) {
+ die __x("{prog}: No operating system could be detected inside this disk image.\n\nThis may be because the file is not a disk image, or is not a virtual machine\nimage, or because the OS type is not understood by libguestfs.\n\nIf you feel this is an error, please file a bug report including as much\ninformation about the disk image as possible.\n",
+ prog => basename ($0));
+}
+if (@roots > 1) {
+ die __x("{prog}: multiboot operating systems are not supported.\n",
+ prog => basename ($0))
+}
+my %fses = $g->inspect_get_mountpoints ($roots[0]);
+my @fses = sort { length $a <=> length $b } keys %fses;
+foreach (@fses) {
+ $g->mount_options ("", $fses{$_}, $_);
+}
-my ($fh_not_used, $tempname) = tempfile ();
+my ($fh, $tempname) = tempfile (UNLINK => 1);
+my $fddev = "/dev/fd/" . fileno ($fh);
# Allow this to fail in case eg. the file does not exist.
-$g->download($filename, $tempname);
+$g->download ($filename, $fddev);
+
+close $fh or die "close: $!";
my $do_upload = $tempname;
print __"File not changed.\n";
}
} else {
- my ($fh, $tempout) = tempfile ();
+ my ($fh, $tempout) = tempfile (UNLINK => 1);
# Apply a Perl expression to the lines of the file.
open IFILE, $tempname or die "$tempname: $!";
die if $@;
print $fh $_ or die "print: $!";
}
- close $fh;
+ close $fh or die "close: $!";
$do_upload = $tempout;
}
if (defined $do_upload) {
- $g->upload ($do_upload, $filename);
+ # Upload to a new file, so if it fails we don't end up with
+ # a partially written file. Give the new file a completely
+ # random name so we have only a tiny chance of overwriting
+ # some existing file.
+ my $dirname = $filename;
+ $dirname =~ s{/[^/]+$}{/};
+
+ my @chars = ('a'..'z', 'A'..'Z', '0'..'9');
+ my $newname = $dirname;
+ foreach (0..7) {
+ $newname .= $chars[rand @chars];
+ }
+
+ $g->upload ($do_upload, $newname);
+
+ # Backup or overwrite?
+ $g->mv ($filename, "$filename$backup") if defined $backup;
+ $g->mv ($newname, $filename);
+
$g->umount_all ();
$g->sync ();
}
=back
+=head1 SHELL QUOTING
+
+Libvirt guest names can contain arbitrary characters, some of which
+have meaning to the shell such as C<#> and space. You may need to
+quote or escape these characters on the command line. See the shell
+manual page L<sh(1)> for details.
+
=head1 SEE ALSO
L<guestfs(3)>,