/* libguestfs - the guestfsd daemon
- * Copyright (C) 2009 Red Hat Inc.
+ * Copyright (C) 2009-2011 Red Hat Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <config.h>
#include "daemon.h"
#include "actions.h"
-#define MAX_ARGS 16
+#define MAX_ARGS 64
/* Takes optional arguments, consult optargs_bitmask. */
int
-do_mkfs_opts (const char *fstype, const char *device, int blocksize)
+do_mkfs_opts (const char *fstype, const char *device, int blocksize,
+ const char *features, int inode, int sectorsize)
{
const char *argv[MAX_ARGS];
size_t i = 0;
char blocksize_str[32];
+ char inode_str[32];
+ char sectorsize_str[32];
int r;
char *err;
+ char mke2fs[] = "mke2fs";
- argv[i++] = "mkfs";
- argv[i++] = "-t";
- argv[i++] = fstype;
+ /* For ext2/3/4 run the mke2fs program directly. This is because
+ * the mkfs program "eats" some options, in particular the -F
+ * option.
+ */
+ if (STREQ (fstype, "ext2") || STREQ (fstype, "ext3") ||
+ STREQ (fstype, "ext4")) {
+ if (e2prog (mke2fs) == -1)
+ return -1;
+ ADD_ARG (argv, i, mke2fs);
+ }
+ else
+ ADD_ARG (argv, i, "mkfs");
+
+ ADD_ARG (argv, i, "-t");
+ ADD_ARG (argv, i, fstype);
+
+ /* Force mke2fs to create a filesystem, even if it thinks it
+ * shouldn't (RHBZ#690819).
+ */
+ if (STREQ (fstype, "ext2") || STREQ (fstype, "ext3") ||
+ STREQ (fstype, "ext4"))
+ ADD_ARG (argv, i, "-F");
/* mkfs.ntfs requires the -Q argument otherwise it writes zeroes
* to every block and does bad block detection, neither of which
* are useful behaviour for virtual devices.
*/
if (STREQ (fstype, "ntfs"))
- argv[i++] = "-Q";
+ ADD_ARG (argv, i, "-Q");
/* mkfs.reiserfs produces annoying interactive prompts unless you
* tell it to be quiet.
*/
if (STREQ (fstype, "reiserfs"))
- argv[i++] = "-f";
+ ADD_ARG (argv, i, "-f");
/* Same for JFS. */
if (STREQ (fstype, "jfs"))
- argv[i++] = "-f";
+ ADD_ARG (argv, i, "-f");
+
+ if (STREQ (fstype, "xfs"))
+ ADD_ARG (argv, i, "-f");
/* For GFS, GFS2, assume a single node. */
if (STREQ (fstype, "gfs") || STREQ (fstype, "gfs2")) {
- argv[i++] = "-p";
- argv[i++] = "lock_nolock";
+ ADD_ARG (argv, i, "-p");
+ ADD_ARG (argv, i, "lock_nolock");
/* The man page says this is default, but it doesn't seem to be: */
- argv[i++] = "-j";
- argv[i++] = "1";
+ ADD_ARG (argv, i, "-j");
+ ADD_ARG (argv, i, "1");
/* Don't ask questions: */
- argv[i++] = "-O";
+ ADD_ARG (argv, i, "-O");
}
/* Process blocksize parameter if set. */
}
snprintf (blocksize_str, sizeof blocksize_str, "%d", sectors_per_cluster);
- argv[i++] = "-s";
- argv[i++] = blocksize_str;
+ ADD_ARG (argv, i, "-s");
+ ADD_ARG (argv, i, blocksize_str);
}
else if (STREQ (fstype, "ntfs")) {
/* For NTFS map the blocksize into a cluster size. */
snprintf (blocksize_str, sizeof blocksize_str, "%d", blocksize);
- argv[i++] = "-c";
- argv[i++] = blocksize_str;
+ ADD_ARG (argv, i, "-c");
+ ADD_ARG (argv, i, blocksize_str);
}
else {
/* For all other filesystem types, try the -b option. */
snprintf (blocksize_str, sizeof blocksize_str, "%d", blocksize);
- argv[i++] = "-b";
- argv[i++] = blocksize_str;
+ ADD_ARG (argv, i, "-b");
+ ADD_ARG (argv, i, blocksize_str);
+ }
+ }
+
+ if (optargs_bitmask & GUESTFS_MKFS_OPTS_FEATURES_BITMASK) {
+ ADD_ARG (argv, i, "-O");
+ ADD_ARG (argv, i, features);
+ }
+
+ if (optargs_bitmask & GUESTFS_MKFS_OPTS_INODE_BITMASK) {
+ if (!STREQ (fstype, "ext2") && !STREQ (fstype, "ext3") &&
+ !STREQ (fstype, "ext4")) {
+ reply_with_error ("inode size (-I) can only be set on ext2/3/4 filesystems");
+ return -1;
+ }
+
+ if (inode <= 0) {
+ reply_with_error ("inode size must be larger than zero");
+ return -1;
}
+
+ snprintf (inode_str, sizeof inode_str, "%d", inode);
+ ADD_ARG (argv, i, "-I");
+ ADD_ARG (argv, i, inode_str);
}
- argv[i++] = device;
- argv[i++] = NULL;
+ if (optargs_bitmask & GUESTFS_MKFS_OPTS_SECTORSIZE_BITMASK) {
+ if (!STREQ (fstype, "ufs")) {
+ reply_with_error ("sector size (-S) can only be set on ufs filesystems");
+ return -1;
+ }
+
+ if (sectorsize <= 0) {
+ reply_with_error ("sector size must be larger than zero");
+ return -1;
+ }
+
+ snprintf (sectorsize_str, sizeof sectorsize_str, "%d", sectorsize);
+ ADD_ARG (argv, i, "-S");
+ ADD_ARG (argv, i, sectorsize_str);
+ }
- if (i > MAX_ARGS)
- abort ();
+ ADD_ARG (argv, i, device);
+ ADD_ARG (argv, i, NULL);
r = commandv (NULL, &err, argv);
if (r == -1) {
do_mkfs (const char *fstype, const char *device)
{
optargs_bitmask = 0;
- return do_mkfs_opts (fstype, device, 0);
+ return do_mkfs_opts (fstype, device, 0, 0, 0, 0);
}
int
do_mkfs_b (const char *fstype, int blocksize, const char *device)
{
optargs_bitmask = GUESTFS_MKFS_OPTS_BLOCKSIZE_BITMASK;
- return do_mkfs_opts (fstype, device, blocksize);
+ return do_mkfs_opts (fstype, device, blocksize, 0, 0, 0);
}