#include <stdio.h>
#include <stdlib.h>
+#include <inttypes.h>
+#include <string.h>
#include <unistd.h>
-#include <ctype.h>
-#include "../src/guestfs_protocol.h"
+#include "guestfs_protocol.h"
#include "daemon.h"
+#include "c-ctype.h"
#include "actions.h"
+/* Confirmed this is true up to ext4 from the Linux sources. */
+#define EXT2_LABEL_MAX 16
+
+/* Choose which tools like mke2fs to use. For RHEL 5 (only) there
+ * is a special set of tools which support ext2/3/4. eg. On RHEL 5,
+ * mke2fs only supports ext2/3, but mke4fs supports ext2/3/4.
+ *
+ * We specify e4fsprogs in the package list to ensure it is loaded
+ * if it exists.
+ */
+int
+e2prog (char *name)
+{
+ char *p = strstr (name, "e2");
+ if (!p) return 0;
+ p++;
+
+ *p = '4';
+ if (prog_exists (name))
+ return 0;
+
+ *p = '2';
+ if (prog_exists (name))
+ return 0;
+
+ reply_with_error ("cannot find required program %s", name);
+ return -1;
+}
+
char **
do_tune2fs_l (const char *device)
{
char **ret = NULL;
int size = 0, alloc = 0;
- r = command (&out, &err, "/sbin/tune2fs", "-l", device, NULL);
+ char prog[] = "tune2fs";
+ if (e2prog (prog) == -1)
+ return NULL;
+
+ r = command (&out, &err, prog, "-l", device, NULL);
if (r == -1) {
- reply_with_error ("tune2fs: %s", err);
+ reply_with_error ("%s", err);
free (err);
free (out);
return NULL;
p = out;
/* Discard the first line if it contains "tune2fs ...". */
- if (strncmp (p, "tune2fs ", 8) == 0) {
+ if (STRPREFIX (p, "tune2fs ") || STRPREFIX (p, "tune4fs ")) {
p = strchr (p, '\n');
if (p) p++;
else {
- reply_with_error ("tune2fs: truncated output");
+ reply_with_error ("truncated output");
free (out);
return NULL;
}
if (colon) {
*colon = '\0';
- do { colon++; } while (*colon && isspace (*colon));
+ do { colon++; } while (*colon && c_isspace (*colon));
if (add_string (&ret, &size, &alloc, p) == -1) {
free (out);
return NULL;
}
- if (strcmp (colon, "<none>") == 0 ||
- strcmp (colon, "<not available>") == 0 ||
- strcmp (colon, "(none)") == 0) {
+ if (STREQ (colon, "<none>") ||
+ STREQ (colon, "<not available>") ||
+ STREQ (colon, "(none)")) {
if (add_string (&ret, &size, &alloc, "") == -1) {
free (out);
return NULL;
int r;
char *err;
- r = command (NULL, &err, "/sbin/e2label", device, label, NULL);
+ char prog[] = "e2label";
+ if (e2prog (prog) == -1)
+ return -1;
+
+ if (strlen (label) > EXT2_LABEL_MAX) {
+ reply_with_error ("%s: ext2 labels are limited to %d bytes",
+ label, EXT2_LABEL_MAX);
+ return -1;
+ }
+
+ r = command (NULL, &err, prog, device, label, NULL);
if (r == -1) {
- reply_with_error ("e2label: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
char *
do_get_e2label (const char *device)
{
- int r, len;
- char *out, *err;
-
- r = command (&out, &err, "/sbin/e2label", device, NULL);
- if (r == -1) {
- reply_with_error ("e2label: %s", err);
- free (out);
- free (err);
- return NULL;
- }
-
- free (err);
-
- /* Remove any trailing \n from the label. */
- len = strlen (out);
- if (len > 0 && out[len-1] == '\n')
- out[len-1] = '\0';
-
- return out; /* caller frees */
+ return do_vfs_label (device);
}
int
int r;
char *err;
- r = command (NULL, &err, "/sbin/tune2fs", "-U", uuid, device, NULL);
+ char prog[] = "tune2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
+ r = command (NULL, &err, prog, "-U", uuid, device, NULL);
if (r == -1) {
- reply_with_error ("tune2fs -U: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
char *
do_get_e2uuid (const char *device)
{
+ return do_vfs_uuid (device);
+}
+
+int
+do_resize2fs (const char *device)
+{
+ char *err;
int r;
- char *out, *err, *p, *q;
- /* It's not so straightforward to get the volume UUID. We have
- * to use tune2fs -l and then look for a particular string in
- * the output.
- */
+ char prog[] = "resize2fs";
+ if (e2prog (prog) == -1)
+ return -1;
- r = command (&out, &err, "/sbin/tune2fs", "-l", device, NULL);
+ r = command (NULL, &err, prog, device, NULL);
if (r == -1) {
- reply_with_error ("tune2fs -l: %s", err);
- free (out);
+ reply_with_error ("%s", err);
free (err);
- return NULL;
+ return -1;
}
free (err);
+ return 0;
+}
- /* Look for /\nFilesystem UUID:\s+/ in the output. */
- p = strstr (out, "\nFilesystem UUID:");
- if (p == NULL) {
- reply_with_error ("no Filesystem UUID in the output of tune2fs -l");
- free (out);
- return NULL;
- }
+int
+do_resize2fs_size (const char *device, int64_t size)
+{
+ char *err;
+ int r;
- p += 17;
- while (*p && isspace (*p))
- p++;
- if (!*p) {
- reply_with_error ("malformed Filesystem UUID in the output of tune2fs -l");
- free (out);
- return NULL;
- }
+ char prog[] = "resize2fs";
+ if (e2prog (prog) == -1)
+ return -1;
- /* Now 'p' hopefully points to the start of the UUID. */
- q = p;
- while (*q && (isxdigit (*q) || *q == '-'))
- q++;
- if (!*q) {
- reply_with_error ("malformed Filesystem UUID in the output of tune2fs -l");
- free (out);
- return NULL;
+ /* resize2fs itself may impose additional limits. Since we are
+ * going to use the 'K' suffix however we can only work with whole
+ * kilobytes.
+ */
+ if (size & 1023) {
+ reply_with_error ("%" PRIi64 ": size must be a round number of kilobytes",
+ size);
+ return -1;
}
+ size /= 1024;
- *q = '\0';
+ char buf[32];
+ snprintf (buf, sizeof buf, "%" PRIi64 "K", size);
- p = strdup (p);
- if (!p) {
- reply_with_perror ("strdup");
- free (out);
- return NULL;
+ r = command (NULL, &err, prog, device, buf, NULL);
+ if (r == -1) {
+ reply_with_error ("%s", err);
+ free (err);
+ return -1;
}
- free (out);
- return p; /* caller frees */
+ free (err);
+ return 0;
}
int
-do_resize2fs (const char *device)
+do_resize2fs_M (const char *device)
{
char *err;
int r;
- r = command (NULL, &err, "/sbin/resize2fs", device, NULL);
+ char prog[] = "resize2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
+ r = command (NULL, &err, prog, "-M" , device, NULL);
if (r == -1) {
- reply_with_error ("resize2fs: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
char *err;
int r;
- r = command (NULL, &err, "/sbin/e2fsck", "-p", "-f", device, NULL);
- if (r == -1) {
- reply_with_error ("e2fsck: %s", err);
+ char prog[] = "e2fsck";
+ if (e2prog (prog) == -1)
+ return -1;
+
+ /* 0 = no errors, 1 = errors corrected.
+ *
+ * >= 4 means uncorrected or other errors.
+ *
+ * 2, 3 means errors were corrected and we require a reboot. This is
+ * a difficult corner case.
+ */
+ r = commandr (NULL, &err, prog, "-p", "-f", device, NULL);
+ if (r == -1 || r >= 2) {
+ reply_with_error ("%s", err);
free (err);
return -1;
}
char *err;
int r;
+ char prog[] = "mke2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
char blocksize_s[32];
snprintf (blocksize_s, sizeof blocksize_s, "%d", blocksize);
r = command (NULL, &err,
- "/sbin/mke2fs", "-O", "journal_dev", "-b", blocksize_s,
- device, NULL);
+ prog, "-O", "journal_dev", "-b", blocksize_s,
+ device, NULL);
if (r == -1) {
- reply_with_error ("mke2journal: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
char *err;
int r;
+ char prog[] = "mke2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
+ if (strlen (label) > EXT2_LABEL_MAX) {
+ reply_with_error ("%s: ext2 labels are limited to %d bytes",
+ label, EXT2_LABEL_MAX);
+ return -1;
+ }
+
char blocksize_s[32];
snprintf (blocksize_s, sizeof blocksize_s, "%d", blocksize);
r = command (NULL, &err,
- "/sbin/mke2fs", "-O", "journal_dev", "-b", blocksize_s,
- "-L", label,
- device, NULL);
+ prog, "-O", "journal_dev", "-b", blocksize_s,
+ "-L", label,
+ device, NULL);
if (r == -1) {
- reply_with_error ("mke2journal_L: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
char *err;
int r;
+ char prog[] = "mke2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
char blocksize_s[32];
snprintf (blocksize_s, sizeof blocksize_s, "%d", blocksize);
r = command (NULL, &err,
- "/sbin/mke2fs", "-O", "journal_dev", "-b", blocksize_s,
- "-U", uuid,
- device, NULL);
+ prog, "-O", "journal_dev", "-b", blocksize_s,
+ "-U", uuid,
+ device, NULL);
if (r == -1) {
- reply_with_error ("mke2journal_U: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
int
do_mke2fs_J (const char *fstype, int blocksize, const char *device,
- const char *journal)
+ const char *journal)
{
char *err;
int r;
+ char prog[] = "mke2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
char blocksize_s[32];
snprintf (blocksize_s, sizeof blocksize_s, "%d", blocksize);
snprintf (jdev, len+32, "device=%s", journal);
r = command (NULL, &err,
- "/sbin/mke2fs", "-t", fstype, "-J", jdev, "-b", blocksize_s,
- device, NULL);
+ prog, "-t", fstype, "-J", jdev, "-b", blocksize_s,
+ device, NULL);
if (r == -1) {
- reply_with_error ("mke2fs_J: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
int
do_mke2fs_JL (const char *fstype, int blocksize, const char *device,
- const char *label)
+ const char *label)
{
char *err;
int r;
+ char prog[] = "mke2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
+ if (strlen (label) > EXT2_LABEL_MAX) {
+ reply_with_error ("%s: ext2 labels are limited to %d bytes",
+ label, EXT2_LABEL_MAX);
+ return -1;
+ }
+
char blocksize_s[32];
snprintf (blocksize_s, sizeof blocksize_s, "%d", blocksize);
snprintf (jdev, len+32, "device=LABEL=%s", label);
r = command (NULL, &err,
- "/sbin/mke2fs", "-t", fstype, "-J", jdev, "-b", blocksize_s,
- device, NULL);
+ prog, "-t", fstype, "-J", jdev, "-b", blocksize_s,
+ device, NULL);
if (r == -1) {
- reply_with_error ("mke2fs_JL: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}
int
do_mke2fs_JU (const char *fstype, int blocksize, const char *device,
- const char *uuid)
+ const char *uuid)
{
char *err;
int r;
+ char prog[] = "mke2fs";
+ if (e2prog (prog) == -1)
+ return -1;
+
char blocksize_s[32];
snprintf (blocksize_s, sizeof blocksize_s, "%d", blocksize);
snprintf (jdev, len+32, "device=UUID=%s", uuid);
r = command (NULL, &err,
- "/sbin/mke2fs", "-t", fstype, "-J", jdev, "-b", blocksize_s,
- device, NULL);
+ prog, "-t", fstype, "-J", jdev, "-b", blocksize_s,
+ device, NULL);
if (r == -1) {
- reply_with_error ("mke2fs_JU: %s", err);
+ reply_with_error ("%s", err);
free (err);
return -1;
}