git.annexia.org
/
libguestfs.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Quote command line arguments to virt-inspector.
[libguestfs.git]
/
daemon
/
file.c
diff --git
a/daemon/file.c
b/daemon/file.c
index
d8759f0
..
3f07ffc
100644
(file)
--- a/
daemon/file.c
+++ b/
daemon/file.c
@@
-18,8
+18,6
@@
#include <config.h>
#include <config.h>
-#define _GNU_SOURCE /* for futimens(2) and getline(3) */
-
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
@@
-32,15
+30,16
@@
#include "actions.h"
int
#include "actions.h"
int
-do_touch (c
onst c
har *path)
+do_touch (char *path)
{
int fd;
{
int fd;
+ int r;
NEED_ROOT (-1);
ABS_PATH (path, -1);
CHROOT_IN;
NEED_ROOT (-1);
ABS_PATH (path, -1);
CHROOT_IN;
- fd = open (path, O_WRONLY | O_CREAT | O_NOCTTY
| O_NONBLOCK
, 0666);
+ fd = open (path, O_WRONLY | O_CREAT | O_NOCTTY, 0666);
CHROOT_OUT;
if (fd == -1) {
CHROOT_OUT;
if (fd == -1) {
@@
-48,18
+47,27
@@
do_touch (const char *path)
return -1;
}
return -1;
}
- if (futimens (fd, NULL) == -1) {
+#ifdef HAVE_FUTIMENS
+ r = futimens (fd, NULL);
+#else
+ r = futimes (fd, NULL);
+#endif
+ if (r == -1) {
reply_with_perror ("futimens: %s", path);
close (fd);
return -1;
}
reply_with_perror ("futimens: %s", path);
close (fd);
return -1;
}
- close (fd);
+ if (close (fd) == -1) {
+ reply_with_perror ("close: %s", path);
+ return -1;
+ }
+
return 0;
}
char *
return 0;
}
char *
-do_cat (c
onst c
har *path)
+do_cat (char *path)
{
int fd;
int alloc, size, r, max;
{
int fd;
int alloc, size, r, max;
@@
-130,7
+138,7
@@
do_cat (const char *path)
}
char **
}
char **
-do_read_lines (c
onst c
har *path)
+do_read_lines (char *path)
{
char **r = NULL;
int size = 0, alloc = 0;
{
char **r = NULL;
int size = 0, alloc = 0;
@@
-182,7
+190,7
@@
do_read_lines (const char *path)
}
int
}
int
-do_rm (c
onst c
har *path)
+do_rm (char *path)
{
int r;
{
int r;
@@
-202,7
+210,7
@@
do_rm (const char *path)
}
int
}
int
-do_chmod (int mode, c
onst c
har *path)
+do_chmod (int mode, char *path)
{
int r;
{
int r;
@@
-222,7
+230,7
@@
do_chmod (int mode, const char *path)
}
int
}
int
-do_chown (int owner, int group, c
onst c
har *path)
+do_chown (int owner, int group, char *path)
{
int r;
{
int r;
@@
-242,7
+250,7
@@
do_chown (int owner, int group, const char *path)
}
int
}
int
-do_exists (c
onst c
har *path)
+do_exists (char *path)
{
int r;
{
int r;
@@
-257,7
+265,7
@@
do_exists (const char *path)
}
int
}
int
-do_is_file (c
onst c
har *path)
+do_is_file (char *path)
{
int r;
struct stat buf;
{
int r;
struct stat buf;
@@
-282,7
+290,7
@@
do_is_file (const char *path)
}
int
}
int
-do_write_file (c
onst char *path, const
char *content, int size)
+do_write_file (c
har *path,
char *content, int size)
{
int fd;
{
int fd;
@@
-293,7
+301,7
@@
do_write_file (const char *path, const char *content, int size)
size = strlen (content);
CHROOT_IN;
size = strlen (content);
CHROOT_IN;
- fd = open (path, O_WRONLY | O_
CREAT | O_NOCTTY | O_NONBLOCK
, 0666);
+ fd = open (path, O_WRONLY | O_
TRUNC | O_CREAT | O_NOCTTY
, 0666);
CHROOT_OUT;
if (fd == -1) {
CHROOT_OUT;
if (fd == -1) {
@@
-317,22
+325,27
@@
do_write_file (const char *path, const char *content, int size)
/* This runs the 'file' command. */
char *
/* This runs the 'file' command. */
char *
-do_file (c
onst c
har *path)
+do_file (char *path)
{
char *out, *err;
{
char *out, *err;
- int r, len;
+ int r, len
, freeit = 0
;
char *buf;
char *buf;
- NEED_ROOT
(
NULL);
+ NEED_ROOT
_OR_IS_DEVICE (path,
NULL);
ABS_PATH (path, NULL);
ABS_PATH (path, NULL);
- len = strlen (path) + 9;
- buf = malloc (len);
- if (!buf) {
- reply_with_perror ("malloc");
- return NULL;
+ if (strncmp (path, "/dev/", 5) == 0)
+ buf = (char *) path;
+ else {
+ len = strlen (path) + 9;
+ buf = malloc (len);
+ if (!buf) {
+ reply_with_perror ("malloc");
+ return NULL;
+ }
+ snprintf (buf, len, "/sysroot%s", path);
+ freeit = 1;
}
}
- snprintf (buf, len, "/sysroot%s", path);
/* file(1) manpage claims "file returns 0 on success, and non-zero on
* error", but this is evidently not true. It always returns 0, in
/* file(1) manpage claims "file returns 0 on success, and non-zero on
* error", but this is evidently not true. It always returns 0, in
@@
-340,13
+353,13
@@
do_file (const char *path)
* first.
*/
if (access (buf, R_OK) == -1) {
* first.
*/
if (access (buf, R_OK) == -1) {
- free (buf);
+
if (freeit)
free (buf);
reply_with_perror ("access: %s", path);
return NULL;
}
r = command (&out, &err, "file", "-bsL", buf, NULL);
reply_with_perror ("access: %s", path);
return NULL;
}
r = command (&out, &err, "file", "-bsL", buf, NULL);
- free (buf);
+
if (freeit)
free (buf);
if (r == -1) {
free (out);
if (r == -1) {
free (out);